Skip to content

Add the comment text that will be used to comment on stale discussions #69778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 6, 2024
Merged

Add the comment text that will be used to comment on stale discussions #69778

merged 16 commits into from
Mar 6, 2024

Conversation

mgriffin
Copy link
Contributor

I've added in the comment text from https://github.com/github/customer-success-engineering/issues/1490#issuecomment-1756356610 and added some reporting so that we can see which discussions will be affected.

As of now, none of the discussions will be commented on, but once we're happy that we've targeted the correct ones, I can change that before merging this PR.

I'm going to run the Action manually from this branch before it can comment on any discussions to make sure that everything is working as expected.

@mgriffin mgriffin self-assigned this Oct 11, 2023
@StemmlerSisters

This comment was marked as off-topic.

Sign in to view
@mojtabaahmadi1367

This comment was marked as off-topic.

Sign in to view
@mgriffin mgriffin force-pushed the mgriffin/stale-text branch from 55c02fe to a923888 Compare October 19, 2023 12:46
yordis
yordis reviewed Oct 20, 2023
View reviewed changes
.github/actions/comment Outdated
only_these_categories = ["Copilot"]

body =<<BODY
🕒 **Stale Discussion Alert** 🕒
Copy link

@yordis yordis Oct 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
🕒 **Stale Discussion Alert** 🕒
🕒 **Discussion Activity Reminder** 🕒

I am not sure if my suggestion is the best, but what I feel strong about it is to avoid the usage of the word "Stale", such word is used across Issues and Pull Request with a particular connotation and expectation that I do not think it is applicable here.

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if my suggestion is the best, but what I feel strong about it is to avoid the usage of the word "Stale", such word is used across Issues and Pull Request with a particular connotation and expectation that I do not think it is applicable here.

This comment was marked as off-topic.

Sign in to view

minzo23
minzo23 reviewed Oct 21, 2023
View reviewed changes
Copy link

@minzo23 minzo23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😊

@scoubasteve

This comment was marked as off-topic.

Sign in to view
@hothanhloc68 hothanhloc68 mentioned this pull request Nov 4, 2023
Closed
@sharifboydev

This comment was marked as spam.

Sign in to view
BobMarleyek
BobMarleyek reviewed Nov 10, 2023
View reviewed changes
.github/actions/comment
@@ -6,22 +6,41 @@ require_relative "../lib/github"
stale_label_id = "LA_kwDOEfmk4M8AAAABYVCU-g"
owner = "community"
repo = "community"
only_these_categories = ["Copilot", "Projects and Issues", "Accessibility"]

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@Kopipa

This comment was marked as off-topic.

Sign in to view
@prechayimmee

This comment was marked as off-topic.

Sign in to view
@bipro-b

This comment was marked as off-topic.

Sign in to view
gdamiaN538

This comment was marked as off-topic.

Sign in to view

Bangyourkitty

This comment was marked as off-topic.

Sign in to view

@Bangyourkitty

This comment was marked as off-topic.

Sign in to view
Bangyourkitty

This comment was marked as off-topic.

Sign in to view

@TEMU2000

This comment was marked as off-topic.

Sign in to view
FabianaCampanari

This comment was marked as off-topic.

Sign in to view

cyny39

This comment was marked as off-topic.

Sign in to view

@cyny39 cyny39 mentioned this pull request Feb 18, 2024
Open
@Justman100

This comment was marked as off-topic.

Sign in to view
@GAMECHANGE

This comment was marked as off-topic.

Sign in to view
1 similar comment
@GAMECHANGE
Copy link

djeva

@alfecaeu92

This comment was marked as off-topic.

Sign in to view
@samzafar26

This comment was marked as off-topic.

Sign in to view
@mgriffin
Change wording from Stale to Dormant
305110d 
As suggested in PR review

Co-authored-by: @yordis <yordis@github.com>
@osppro

This comment was marked as off-topic.

Sign in to view
gdamiaN538

This comment was marked as off-topic.

Sign in to view

jricciardi
jricciardi requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jricciardi jricciardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor copy change requested :)

jricciardi
jricciardi approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jricciardi jricciardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derp, I had forgotten I can edit this. I removed the 'stale' copy on the branch. This is now good to go

@jricciardi jricciardi merged commit cc3e99d into main Mar 6, 2024
@jricciardi jricciardi deleted the mgriffin/stale-text branch March 6, 2024 21:25
@jricciardi jricciardi restored the mgriffin/stale-text branch March 6, 2024 21:26
@mgriffin mgriffin deleted the mgriffin/stale-text branch March 7, 2024 10:28
ettaboyle
ettaboyle reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ettaboyle ettaboyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@GAMECHANGE
Copy link

Thank you

@osppro
Copy link

osppro commented Mar 22, 2024

But still shows some errors

@Rynkunas

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ettaboyle ettaboyle ettaboyle left review comments

@jricciardi jricciardi jricciardi approved these changes

+13 more reviewers

@GAMECHANGE GAMECHANGE GAMECHANGE left review comments

@TEMU2000 TEMU2000 TEMU2000 left review comments

@BobMarleyek BobMarleyek BobMarleyek left review comments

@jsoref jsoref jsoref left review comments

@FabianaCampanari FabianaCampanari FabianaCampanari left review comments

@cyny39 cyny39 cyny39 left review comments

@samzafar26 samzafar26 samzafar26 left review comments

@minzo23 minzo23 minzo23 left review comments

@Ductini2703 Ductini2703 Ductini2703 left review comments

@Bangyourkitty Bangyourkitty Bangyourkitty left review comments

@gdamiaN538 gdamiaN538 gdamiaN538 left review comments

@yordis yordis yordis left review comments

@ramsemune123 ramsemune123 ramsemune123 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@mgriffin mgriffin

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.