Serialize case objects as literal strings #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jodersky |
tdroxler
added a commit
to alephium/alephium
that referenced
this pull request
Nov 21, 2022
Case objects don't seem to work anymore as enum due to: com-lihaoyi/upickle#382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now,
case object Foois now serialized as"pkg.path.Foo", rather than{"$type": "pkg.path.Foo"}. This simplifies the output, and makes serializedsealed trait/case objecthierarchies look much more like simple enumerations when serialized. This harmonizes them with the simple serialization of Scalaenums in #378.case classes, even with zero parameters, are still serialized using the{"$type": "pkg.path.Foo"}encoding.This is a breaking change; uPickle with this change continues to be able to read the old format, but older versions of uPickle will not be able to read the new format. This will need to go into uPickle 2.0.0, with appropriate migration support to smooth the transition