Add named tuples #662
Merged
Add named tuples #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
commented
Apr 20, 2025
| @@ -319,6 +322,31 @@ object upickle extends Module{ | |||
| def moduleDeps = super.moduleDeps ++ Seq(ujson.native().test, core.native().test) | |||
| } | |||
| } | |||
|
|
|||
| object `named-tuples` extends Module { | |||
There was a problem hiding this comment.
I would assume these need some sort of "RC" version added if you publish before scala 3.7.0 is out
c2cf47b to
ea5b3e9
Compare
|
Looks good to me, let's wait till Scala 3.7.0-final is out following week before merging this |
Move read writers into trait, with a type parameter which can be instantiated by some concrete upickle cake stack. concrete objects for default and legacy. also add `strict` mode that requires exact match of fields when deserializing.
1f55c71 to
e4bfad2
Compare
|
Bumped for 3.7.0 |
lihaoyi
added a commit
to com-lihaoyi/mill
that referenced
this pull request
May 18, 2025
Pulls in @bishabosha's work in com-lihaoyi/upickle#662, which gives us an opt-in implicit for Scala >=3.7.0 that lets us serialize named tuples as JSON dictionaries CC @lefou
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the mill version needs a bump to fix a conflict in classpath resolution for the scala 3 library.