Use build info for versions in kotlinlib #3633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Sep 30, 2024
|
Thanks @0xnm ! |
lefou
reviewed
Oct 2, 2024
Comment on lines
+195
to
+205
| val koverVersion = "0.8.3" | ||
| val koverCli = ivy"org.jetbrains.kotlinx:kover-cli:$koverVersion" | ||
| val koverJvmAgent = ivy"org.jetbrains.kotlinx:kover-jvm-agent:$koverVersion" | ||
| val ktfmtVersion = "0.52" | ||
| val ktfmt = ivy"com.facebook:ktfmt:$ktfmtVersion" | ||
| val detektVersion = "1.23.7" | ||
| val detektCli = ivy"io.gitlab.arturbosch.detekt:detekt-cli:$detektVersion" | ||
| val dokkaVersion = "1.9.20" | ||
| val dokkaCli = ivy"org.jetbrains.dokka:dokka-cli:$dokkaVersion" | ||
| val dokkaBase = ivy"org.jetbrains.dokka:dokka-base:$dokkaVersion" | ||
| val dokkaAnalysisDescriptors = ivy"org.jetbrains.dokka:analysis-kotlin-descriptors:$dokkaVersion" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor cleanup for the previous work on the Kotlin-related modules:
JavaModulefor Ktfmt support, because we don't need the code to be compiled in this module, so declaring Kotlin version there was looking a bit strange. In fact onlysources()method is needed, which is available in theJavaModule. In the futureKotlinModulemay be split into different traits: the one which collects Kotlin+Java files, but doesn't do any compilation (so Kotlin version is not needed) and the one which actually does compilation.