-
-
Notifications
You must be signed in to change notification settings - Fork 414
More dependency updates #1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More dependency updates #1933
Conversation
mill mill.scalalib.Dependency/showUpdates
https://github.com/cbeust/testng/blob/master/CHANGES.txt |
…s://mvnrepository.com/artifact/org.scala-lang.modules/scala-parser-combinators. 2. Test with latest twirl-compiler
Hi @IdiosApps, I really appreciate your efforts to bump dependencies. I'd prefer to submit bumps in dedicated pull requests (unless they are required for a special feature). This allows us to better track their impact and isolate issues. Also, most of them are automatically bumped by Scala Steward, and some are simply incompatible. When done in separate PRs, is't easier to find previous (historic) issues, findings and decisions. |
Sure. The PR kind of changed into something more useful as I tried to fix CI jobs. I can split out updates scala steward would never hit (proguard, twirrlib, flway?) into their own PRs. |
This has now all been split out. Closing the PR, thanks. |
Scala steward not updating a few dependencies
Found a few dependencies scala steward may not have caught.
Found with
mill mill.scalalib.Dependency/showUpdates
Some are quite new
some are quite a bit older
I don't see anything intentionally pinning the scalafmt-dynamic update to an older version in .scala-steward.conf.
This bit of the PR aims to give a bit of data to help with scala-steward-org/scala-steward#2664
Update a few hidden dependencies
My local test/compilation was also failing on JDK17. I found a few "hidden" dependencies that Scala-steward wouldn't find in the contrib modules, like proguard and scala-parser-combinators (the latter should let latest twirllib work, on Scala 2.13).