Skip to content

Conversation

james-s-w-clark
Copy link
Contributor

@james-s-w-clark james-s-w-clark commented Jul 11, 2022

Scala steward not updating a few dependencies

Found a few dependencies scala steward may not have caught.
Found with mill mill.scalalib.Dependency/showUpdates

Some are quite new

  • fansi 0.4.0, 2 days ago (which in fact has been picked up by Scala Steward, so I remove it from the PR)

some are quite a bit older

  • scalafmt-dynamic 3.4.3 (feb 2022) -> 3.5.8 (jun 2022). Both 2.12/2.13 compatible. mvnrepository.com

I don't see anything intentionally pinning the scalafmt-dynamic update to an older version in .scala-steward.conf.

This bit of the PR aims to give a bit of data to help with scala-steward-org/scala-steward#2664


Update a few hidden dependencies

My local test/compilation was also failing on JDK17. I found a few "hidden" dependencies that Scala-steward wouldn't find in the contrib modules, like proguard and scala-parser-combinators (the latter should let latest twirllib work, on Scala 2.13).

mill mill.scalalib.Dependency/showUpdates
@james-s-w-clark james-s-w-clark changed the title Add a few updates for deps, found with More dependency updates Jul 11, 2022
@james-s-w-clark
Copy link
Contributor Author

james-s-w-clark commented Jul 11, 2022

https://github.com/cbeust/testng/blob/master/CHANGES.txt
7.6.0 Fixed: GITHUB-2637: Upgrade to JDK11 as the minimum JDK requirements (Krishnan Mahadevan)
Reverted this upgrade, as we have Java 8 in the CI matrix

@lefou
Copy link
Member

lefou commented Jul 12, 2022

Hi @IdiosApps, I really appreciate your efforts to bump dependencies. I'd prefer to submit bumps in dedicated pull requests (unless they are required for a special feature). This allows us to better track their impact and isolate issues. Also, most of them are automatically bumped by Scala Steward, and some are simply incompatible. When done in separate PRs, is't easier to find previous (historic) issues, findings and decisions.

@james-s-w-clark
Copy link
Contributor Author

james-s-w-clark commented Jul 12, 2022

Hi @IdiosApps, I really appreciate your efforts to bump dependencies. I'd prefer to submit bumps in dedicated pull requests (unless they are required for a special feature). This allows us to better track their impact and isolate issues. Also, most of them are automatically bumped by Scala Steward, and some are simply incompatible. When done in separate PRs, is't easier to find previous (historic) issues, findings and dicissions.

Sure. The PR kind of changed into something more useful as I tried to fix CI jobs. I can split out updates scala steward would never hit (proguard, twirrlib, flway?) into their own PRs.
I believe Scala Steward should be updating some things (scalafmt-dynamic 3.4.3 (feb 2022) -> 3.5.8 (jun 2022). Both 2.12/2.13 compatible. mvnrepository.com, but hasn't so I will raise separate PRs for those too

@james-s-w-clark
Copy link
Contributor Author

This has now all been split out. Closing the PR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants