Skip to content

build: use object for webpack externals configuration #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 10, 2020
Merged

build: use object for webpack externals configuration #501

merged 7 commits into from
Aug 10, 2020

Conversation

thijstriemstra
Copy link
Member

fixes #487
fixes #493
fixes #497

@thijstriemstra thijstriemstra mentioned this pull request Aug 10, 2020
Closed
@coveralls
Copy link

coveralls commented Aug 10, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 74.154% when pulling be7f8bc on webpack-externals into 363858f on master.

@thijstriemstra thijstriemstra merged commit 6826eb4 into master Aug 10, 2020
@thijstriemstra thijstriemstra deleted the webpack-externals branch August 10, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shouldn't external be "video.js" and not "videojs" ? angular 9 video record is not supporting Cannot compile in ReactJs
2 participants
@thijstriemstra @coveralls