Skip to content

Conversation

efirs
Copy link
Contributor

@efirs efirs commented Sep 25, 2018

No description provided.

@colinmarc
Copy link
Owner

colinmarc commented Sep 26, 2018

Hi @efirs! Thanks for this and the other contributions. I'll try to look at all of them today.

For this one: what is the specific problem this solves? Is it possible to add a test case that breaks without this code?

Evgeniy Firsov added 2 commits September 26, 2018 12:20
Reviewed By: ot

Signed-off-by: Evgeniy Firsov <firsov@uber.com>
Signed-off-by: Evgeniy Firsov <firsov@uber.com>
@efirs efirs force-pushed the datanode_heartbeat branch from 387aecb to 2e566e0 Compare September 26, 2018 19:22
@efirs
Copy link
Contributor Author

efirs commented Sep 26, 2018

The test case is:

Write()
Sleep(1.5*Minute)
Write()

Second write fails without this fix.
The fix adds missing functionality from: https://apache.googlesource.com/hadoop/+/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java

I've added the test case, but it increases test time by 1.5 minutes, the better one would lower HDFS idle timeout.

@colinmarc
Copy link
Owner

Merged in #208. Sorry to make you wait more than a year!

@colinmarc colinmarc closed this Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants