Skip to content

PR: Fix incorrect "CO2" concentration scaling in colour.phenomena.rayleigh.F_air_Bodhaine1999 definition. #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

PR: Fix incorrect "CO2" concentration scaling in colour.phenomena.rayleigh.F_air_Bodhaine1999 definition. #1167

merged 1 commit into from
Jun 7, 2023

Conversation

KelSolaar
Copy link
Member

Summary

Title says it all, closes #307, thanks to @chnmasta05!

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • [N/A] The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.3 milestone Jun 7, 2023
@coveralls
Copy link

Coverage Status

coverage: 99.781%. remained the same when pulling 5f8e6db on feature/rayleigh into 284f586 on develop.

@KelSolaar KelSolaar merged commit 68342cb into develop Jun 7, 2023
@KelSolaar KelSolaar deleted the feature/rayleigh branch June 7, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.3
Development

Successfully merging this pull request may close these issues.

Investigate discrepancies in "Scattering Cross Section" computations compared to ground truth.
2 participants
@KelSolaar @coveralls