Skip to content

PR: Implement support for "Kirk (2019)" "Yrg" colourspace. #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2023

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented May 14, 2023

Summary

This PR implements support for Kirk (2019) Yrg colourspace. The precision on roundtrips is not fantastic but should be good enough for practical purposes.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.3 milestone May 14, 2023
@coveralls
Copy link

Coverage Status

Coverage: 99.785% (+0.0009%) from 99.784% when pulling b93783a on feature/yrg into 96d9c5d on develop.

@KelSolaar KelSolaar merged commit 1df6010 into develop May 14, 2023
@KelSolaar
Copy link
Member Author

Merging directly as it is straightforward.

@KelSolaar KelSolaar deleted the feature/yrg branch July 21, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants