Skip to content

PR: Implement support for "CCT" to "mired" conversion. #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2023
Merged

PR: Implement support for "CCT" to "mired" conversion. #1114

merged 3 commits into from
Mar 5, 2023

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented Mar 4, 2023 •
edited
Loading

Summary

This PR adds the colour.mired_to_CCT and colour.CCT_to_mired definitions to support micro reciprocal degree conversion.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@coveralls
Copy link

coveralls commented Mar 4, 2023 •
edited
Loading

Coverage Status

Coverage: 77.345% (+0.02%) from 77.323% when pulling 3431209 on feature/mired into 80a8f21 on develop.

@KelSolaar
Copy link
Member Author

KelSolaar commented Mar 5, 2023 •
edited
Loading

I'm also taking that opportunity to add a planckian_locus_use_mireds kwargs to the colour.plotting.temperature.plot_planckian_locus definition figure:

image

@KelSolaar KelSolaar merged commit 7e0a665 into develop Mar 5, 2023
@KelSolaar KelSolaar deleted the feature/mired branch March 5, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KelSolaar @coveralls