Skip to content

Moved glog version variable export out of MSVC scope. #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

Moved glog version variable export out of MSVC scope. #140

merged 1 commit into from
Nov 27, 2024

Conversation

JonasKonrad
Copy link
Contributor

Moved glog version variable export out of MSVC scope in FindDependencies.cmake.

@JonasKonrad JonasKonrad mentioned this pull request Nov 21, 2024
Open
@ahojnnes ahojnnes enabled auto-merge (squash) November 21, 2024 15:34
@ahojnnes
Copy link
Contributor

Thank you for the fix. LGTM.

@ahojnnes ahojnnes merged commit ae015fd into colmap:main Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpanaf lpanaf lpanaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonasKonrad @ahojnnes @lpanaf