Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coil-kt/coil
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.6.0
Choose a base ref
...
head repository: coil-kt/coil
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.7.0
Choose a head ref
  • 7 commits
  • 24 files changed
  • 3 contributors

Commits on Feb 23, 2024

  1. Configuration menu
    Copy the full SHA
    95edaae View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Improve RealImageLoader.execute to properly call async request (#2205)

    * Improve RealImageLoader.execute to properly call async request
    
    * Add experiments to get information about performance
    
    * Revert fix
    
    * Add comment what's blocking
    
    * Fix spotless
    
    * Tweak benchmarks + add traces
    
    Update benchmarks
    
    Experiment removing mutableState
    
    Before:
    AsyncImagePainter.onRememberedAverageMs        min   0.1,   median   0.1,   max   0.1
    AsyncImagePainter.onRememberedCount            min 130.0,   median 139.0,   max 146.0
    AsyncImagePainter.onRememberedMs               min   9.3,   median  12.5,   max  16.3
    frameDurationCpuMs                             P50    4.1,   P90    9.1,   P95   20.0,   P99   99.3
    
    After:
    AsyncImagePainter.onRememberedAverageMs        min   0.1,   median   0.1,   max   0.1
    AsyncImagePainter.onRememberedCount            min 130.0,   median 141.0,   max 148.0
    AsyncImagePainter.onRememberedMs               min   8.3,   median  10.5,   max  15.8
    frameDurationCpuMs                             P50    4.4,   P90    8.6,   P95   12.0,   P99   95.1
    
    Don't launch job for compose
    
    before
    AsyncImagePainter.onRememberedAverage_µs       min     77.3,   median    101.5,   max    116.7
    AsyncImagePainter.onRememberedCount            min    130.0,   median    130.0,   max    146.0
    AsyncImagePainter.onRemembered_µs              min 10,048.4,   median 13,880.2,   max 16,900.0
    timeToInitialDisplayMs                         min    256.8,   median    281.7,   max    358.9
    frameDurationCpuMs                             P50       5.1,   P90       9.2,   P95      13.3,   P99     117.0
    
    after
    AsyncImagePainter.onRememberedAverage_µs       min     68.9,   median     78.7,   max     91.1
    AsyncImagePainter.onRememberedCount            min    128.0,   median    141.0,   max    146.0
    AsyncImagePainter.onRemembered_µs              min  8,956.1,   median 11,163.1,   max 13,111.9
    timeToInitialDisplayMs                         min    234.1,   median    276.5,   max    325.7
    frameDurationCpuMs                             P50       4.5,   P90       8.9,   P95      15.5,   P99     120.3
    
    * Experiment removing Compose State
    
    Before:
    AsyncImagePainter.onRememberedAverageMs        min   0.1,   median   0.1,   max   0.1
    AsyncImagePainter.onRememberedCount            min 130.0,   median 139.0,   max 146.0
    AsyncImagePainter.onRememberedMs               min   9.3,   median  12.5,   max  16.3
    frameDurationCpuMs                             P50    4.1,   P90    9.1,   P95   20.0,   P99   99.3
    
    After:
    AsyncImagePainter.onRememberedAverageMs        min   0.1,   median   0.1,   max   0.1
    AsyncImagePainter.onRememberedCount            min 130.0,   median 141.0,   max 148.0
    AsyncImagePainter.onRememberedMs               min   8.3,   median  10.5,   max  15.8
    frameDurationCpuMs                             P50    4.4,   P90    8.6,   P95   12.0,   P99   95.1
    
    * Don't launch job for compose
    
    before
    AsyncImagePainter.onRememberedAverage_µs       min     77.3,   median    101.5,   max    116.7
    AsyncImagePainter.onRememberedCount            min    130.0,   median    130.0,   max    146.0
    AsyncImagePainter.onRemembered_µs              min 10,048.4,   median 13,880.2,   max 16,900.0
    timeToInitialDisplayMs                         min    256.8,   median    281.7,   max    358.9
    frameDurationCpuMs                             P50       5.1,   P90       9.2,   P95      13.3,   P99     117.0
    
    after
    AsyncImagePainter.onRememberedAverage_µs       min     68.9,   median     78.7,   max     91.1
    AsyncImagePainter.onRememberedCount            min    128.0,   median    141.0,   max    146.0
    AsyncImagePainter.onRemembered_µs              min  8,956.1,   median 11,163.1,   max 13,111.9
    timeToInitialDisplayMs                         min    234.1,   median    276.5,   max    325.7
    frameDurationCpuMs                             P50       4.5,   P90       8.9,   P95      15.5,   P99     120.3
    
    * Cleanup
    
    * Fix dependency with version catalog
    
    * Cleanup
    
    * Revert API changes
    mlykotom authored May 10, 2024
    Configuration menu
    Copy the full SHA
    bacaba0 View commit details
    Browse the repository at this point in the history
  2. Fix spotlessCheck.

    colinrtwhite committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b53f530 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Update to Kotlin 2.0.

    colinrtwhite committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2f64ffd View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Fix duplicate network call for chunked responses (#2363)

    * Fix duplicate network call for chunked responses
    
    * Avoid allocating a new peek source
    
    Co-authored-by: Colin White <colin@colinwhite.me>
    
    ---------
    
    Co-authored-by: Colin White <colin@colinwhite.me>
    ferinagy and colinrtwhite authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9135616 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    f34b98f View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Prepare 2.7.0.

    colinrtwhite committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    ce14e14 View commit details
    Browse the repository at this point in the history
Loading