Skip to content

Do a classmap replace across the entire classmap_directory folder #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Do a classmap replace across the entire classmap_directory folder #42

merged 1 commit into from
Jun 2, 2020

Conversation

BrianHenryIE
Copy link
Contributor

This is a fix for the Google PHP API having child package classes which extend classes in the parent package.

Mozart assumes only parent packages extend child package classes.

This does not feel like a robust change, but it does address the problem correctly.

@coenjacobs
Copy link
Owner

Is this still required after #39 is merged?

@coenjacobs
Copy link
Owner

Verified this still has a use case. Will include this in the next beta release.

@coenjacobs coenjacobs merged commit 8d60334 into coenjacobs:master Jun 2, 2020
@BrianHenryIE BrianHenryIE mentioned this pull request Sep 4, 2020
Open
@BrianHenryIE BrianHenryIE deleted the classmap-replacing-in-child-packages branch May 3, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrianHenryIE @coenjacobs