Add config option to for deleting vendor directories #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a check so in no circumstance is a package vendor directory deleted if it is a symlink. |
|
Any delete actions should be opt-in. |
|
Good idea to add an optional flag to bypass this behaviour. I can see how this helps developers debug things from their local paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often edit files and run
mozart composefrom the command line to update them. This was an unexpected change! This PR adds a config option,delete_vendor_directories, for disabling the behaviour.The default behaviour is still to delete, which I'd argue is bad. Better to err on the side of caution, but allow the functionality in config.
I presume part of the motivation was because of IDE code completion suggesting multiple classes. I've begun to address this in PhpStorm with a composer plugin which reads Mozart's config and excludes packages listed: BrianHenryIE/composer-phpstorm. It still needs work, particularly that it doesn't yet read those packages' requires.