Skip to content

refactor: update preload script to exclude util_bootstrap #9649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

refactor: update preload script to exclude util_bootstrap #9649

merged 1 commit into from
Jul 30, 2025

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Jul 29, 2025

Description
Followup preload #9562

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr changed the title fix: update preload exlude util_bootstrap fix: update preload exclude util_bootstrap Jul 29, 2025
@ddevsr ddevsr requested review from michalsn and paulbalandan July 29, 2025 10:46
@ddevsr ddevsr added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 29, 2025
@paulbalandan
Copy link
Member

How can I test this?

@ddevsr
Copy link
Collaborator Author

ddevsr commented Jul 29, 2025

Use v4.6.2 with current condition

@michalsn
Copy link
Member

Could you provide more context? Is this actually a fix or just an update of the preload script? Why is this needed?

Sorry, but I don't have opcache installed locally on this machine, to check what is going on.

@ddevsr
Copy link
Collaborator Author

ddevsr commented Jul 29, 2025 •
edited
Loading

Today, i have upgraded on production from v4.6.1 with running opcache preload to v4.6.2. Related to this files in my fpm service, check on development server same result. Only upgrade version (with cache removed)

@ddevsr
Copy link
Collaborator Author

ddevsr commented Jul 29, 2025

Actual just update preload i think, i already exclude for now, Not tested more how actually works in utils_bootstrap

michalsn
michalsn approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, util_bootstrap.php is a newly created file and isn't used by web apps, so I think it's reasonable to exclude it.

@michalsn michalsn changed the title fix: update preload exclude util_bootstrap refactor: update preload exclude util_bootstrap Jul 29, 2025
@michalsn michalsn added refactor Pull requests that refactor code and removed bug Verified issues on the current code behavior or pull requests that will fix them labels Jul 29, 2025
@paulbalandan paulbalandan changed the title refactor: update preload exclude util_bootstrap refactor: update preload script to exclude util_bootstrap Jul 29, 2025
@paulbalandan paulbalandan merged commit 2f6ca33 into codeigniter4:develop Jul 30, 2025
8 checks passed
@paulbalandan
Copy link
Member

Thank you @ddevsr

@ddevsr ddevsr deleted the patch-3 branch July 30, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddevsr @paulbalandan @michalsn