fix: add filename parameters to inline Content-Disposition headers #9638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datamweb
approved these changes
Jul 16, 2025
samsonasik
approved these changes
Jul 18, 2025
|
Thank you @michalsn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
DownloadResponse::inline()method where filename parameters were missing for content disposition. This caused browsers to fall back to using the last URL segment as the filename instead of the intended filename.The browser will display the filename that was set for image and PDF files.
I added
addslashes()because if the filename contains a quote character ("), it would break the header syntax by prematurely terminating the quoted string.The problem was recognized here: https://forum.codeigniter.com/showthread.php?tid=93147
Checklist: