Skip to content

refactor: add assert on LiveModelTestCase::createModel() #9584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

refactor: add assert on LiveModelTestCase::createModel() #9584

merged 1 commit into from
May 27, 2025

Conversation

paulbalandan
Copy link
Member

Description
Adds a @phpstan-assert to let phpstan know the type of $this->model after calling $this->createModel().

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label May 26, 2025
@paulbalandan paulbalandan merged commit 327c7e1 into codeigniter4:develop May 27, 2025
47 checks passed
@paulbalandan paulbalandan deleted the create-model-tests branch May 27, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

+1 more reviewer

@ddevsr ddevsr ddevsr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @michalsn @ddevsr