-
Notifications
You must be signed in to change notification settings - Fork 54
fix: remove token check for report #461
Conversation
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 83 83
Lines 2938 2938
=======================================
Hits 2820 2820
Misses 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
@@ -80,7 +80,13 @@ def create_report_results_logic( | |||
def send_reports_result_request( | |||
commit_sha, report_code, encoded_slug, service, token, enterprise_url | |||
): | |||
headers = get_token_header_or_fail(token) | |||
tokenless = os.environ.get("TOKENLESS") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the endpoint here supports this
@@ -8,7 +8,7 @@ | |||
from codecov_cli.helpers.config import CODECOV_API_URL | |||
from codecov_cli.helpers.encoder import decode_slug, encode_slug | |||
from codecov_cli.helpers.request import ( | |||
get_token_header_or_fail, | |||
get_token_header, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should still keep get_token_header_or_fail here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your comment is conflicting with the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there was an old version of the PR where get_token_header_or_fail
was being deleted, i meant that we should keep both
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
4 similar comments
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
❌ Failed Test Results:Completed 691 tests with View the full list of failed tests
|
No description provided.