feat(plugin-eslint): add artefact options #1089

BioPhoton · 2025-08-27T16:51:55Z

This PR includes:

refactor generateAuditOutputs to createRunnerFunction
use createRunnerFunction instead of createRunnerConfig
update tests

# Conflicts: # packages/models/src/index.ts # packages/plugin-eslint/src/lib/runner/index.ts

nx-cloud · 2025-08-27T16:52:43Z

View your CI Pipeline Execution ↗ for commit 51a431e

Command	Status	Duration	Result
`nx code-pushup --nx-bail -- compare --verbose`	✅ Succeeded	23s	View ↗
`nx code-pushup --nx-bail -- --verbose`	✅ Succeeded	36s	View ↗
`nx code-pushup --nx-bail -- print-config --verb...`	✅ Succeeded	10m 13s	View ↗

☁️ Nx Cloud last updated this comment at 2025-08-29 16:57:40 UTC

pkg-pr-new · 2025-08-27T16:53:00Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1089

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1089

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1089

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1089

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1089

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1089

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1089

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1089

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1089

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1089

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1089

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1089

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1089

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1089

commit: 51a431e

github-actions · 2025-08-27T17:05:50Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit b7bd386 with previous commit a6d3965.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 40	🔴 33
Documentation	🔴 23	🔴 23
Code coverage	🟢 90	🟢 90
Security	🟡 64	🟡 64	–
Updates	🟡 85	🟡 85	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟡 61	🟡 61	–
Type Safety	🟢 100	🟢 100	–
Bug prevention	🟢 100	🟢 100	–
Miscellaneous	🟢 100	🟢 100	–
Code style	🟢 100	🟢 100	–

👍 1 group improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 6 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
Lighthouse	Performance	🔴 40	🔴 33
JSDoc coverage	Documentation coverage	🔴 23	🔴 23
Code coverage	Code coverage metrics	🟢 90	🟢 90

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Reduce unused JavaScript	🟨 Potential savings of 582 KiB	🟥 Potential savings of 582 KiB
Lighthouse	Remove duplicate modules in JavaScript bundles	🟨 Potential savings of 89 KiB	🟥 Potential savings of 101 KiB
Lighthouse	Largest Contentful Paint	🟥 4.8 s	🟥 11.8 s
Lighthouse	Speed Index	🟥 7.2 s	🟥 7.0 s
Lighthouse	First Contentful Paint	🟥 3.2 s	🟥 3.2 s
Lighthouse	Time to Interactive	🟥 17.8 s	🟥 18.0 s
Lighthouse	Total Blocking Time	🟥 5,270 ms	🟥 4,260 ms
JSDoc coverage	Functions coverage	🟥 519 undocumented functions	🟥 517 undocumented functions
Code coverage	Branch coverage	🟨 86.3 %	🟨 86.3 %
Code coverage	Function coverage	🟩 93 %	🟩 93 %
JSDoc coverage	Variables coverage	🟥 230 undocumented variables	🟥 229 undocumented variables
Lighthouse	Avoids enormous network payloads	🟨 Total size was 2,678 KiB	🟨 Total size was 2,684 KiB
Lighthouse	Minimizes main-thread work	🟥 16.6 s	🟥 14.9 s
Lighthouse	Uses efficient cache policy on static assets	🟨 32 resources found	🟨 32 resources found
Lighthouse	Max Potential First Input Delay	🟥 1,700 ms	🟥 1,370 ms
Lighthouse	JavaScript execution time	🟥 6.2 s	🟥 6.4 s
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Server Backend Latencies	🟩 1,080 ms	🟩 1,260 ms
Lighthouse	Reduce unused CSS	🟥 Potential savings of 113 KiB	🟥 Potential savings of 113 KiB
Lighthouse	Initial server response time was short	🟩 Root document took 420 ms	🟩 Root document took 380 ms
Lighthouse	Network Round Trip Times	🟩 50 ms	🟩 50 ms
Lighthouse	Avoids an excessive DOM size	🟥 2,287 elements	🟥 2,285 elements
JS Packages	Outdated NPM prod dependencies.	🟨 14 outdated package versions (3 major, 6 minor, 5 patch)	🟨 15 outdated package versions (3 major, 7 minor, 5 patch)
Code coverage	Line coverage	🟨 87.5 %	🟨 87.5 %

586 other audits are unchanged.

packages/plugin-eslint/src/lib/eslint-plugin.int.test.ts

packages/plugin-eslint/src/lib/runner.int.test.ts

packages/plugin-eslint/src/lib/runner/index.unit.test.ts

packages/plugin-eslint/src/lib/runner/index.ts

packages/plugin-eslint/src/lib/runner.int.test.ts

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

AS and others added 4 commits July 27, 2025 10:54

feat: add artifaction options to plugin-eslint

1209ed2

Merge branch 'main' into feat/add-artefact-opts-to-eslint-plugin

8b001ae

# Conflicts: # packages/models/src/index.ts # packages/plugin-eslint/src/lib/runner/index.ts

Merge branch 'main' into feat/add-artefact-opts-to-eslint-plugin

4e0ffa3

feat(plugin-eslint): use artifacts options

687bada

github-actions bot assigned BioPhoton Aug 27, 2025

github-actions bot added 🔬 testing writing tests 🧩 eslint-plugin labels Aug 27, 2025

refactor(plugin-eslint): fix int tests

a1732d4

BioPhoton mentioned this pull request Aug 22, 2025

Use artifact generation options in plugin-eslint #1068

Closed

16 tasks

BioPhoton changed the title ~~feat(plugin-eslint): add artefact opts~~ feat(plugin-eslint): add artefact options Aug 27, 2025

BioPhoton marked this pull request as ready for review August 27, 2025 19:04

BioPhoton requested a review from matejchalk as a code owner August 27, 2025 19:04

BioPhoton added 2 commits August 28, 2025 16:42

refactor: remove unused code

5d24b82

refactor: fix int tests 1

5454e03

github-actions bot added the 🛠️ tooling label Aug 28, 2025

Merge branch 'main' into feat/add-artefact-opts-to-eslint-plugin

3695d7d

github-actions bot removed the 🛠️ tooling label Aug 28, 2025

BioPhoton added 2 commits August 28, 2025 18:52

refactor: fix int tests 2

b71d211

refactor: fix lint 1

cb1dbbc

github-actions bot added the 🛠️ tooling label Aug 28, 2025

BioPhoton added 2 commits August 28, 2025 18:57

refactor: fix int test 4

1757b7d

refactor: fix int test 6

f00a6d7

BioPhoton force-pushed the feat/add-artefact-opts-to-eslint-plugin branch from 9bf1de0 to f00a6d7 Compare August 28, 2025 17:18

matejchalk reviewed Aug 29, 2025

View reviewed changes

BioPhoton and others added 3 commits August 29, 2025 17:59

Update packages/plugin-eslint/src/lib/runner.int.test.ts

11ca96e

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/plugin-eslint/src/lib/runner.int.test.ts

33af94d

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/plugin-eslint/src/lib/runner/index.ts

c1951f1

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

BioPhoton and others added 5 commits August 29, 2025 18:01

Update packages/plugin-eslint/src/lib/runner/index.unit.test.ts

b55b1ca

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/plugin-eslint/src/lib/runner/index.unit.test.ts

cd996fd

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/plugin-eslint/src/lib/eslint-plugin.int.test.ts

f838cfb

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Update packages/plugin-eslint/src/lib/runner.int.test.ts

67c2794

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

refactor: improve tests

51a431e

matejchalk approved these changes Aug 29, 2025

View reviewed changes

BioPhoton merged commit 4367e53 into main Aug 29, 2025
17 checks passed

BioPhoton deleted the feat/add-artefact-opts-to-eslint-plugin branch August 29, 2025 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(plugin-eslint): add artefact options #1089

feat(plugin-eslint): add artefact options #1089

Uh oh!

BioPhoton commented Aug 27, 2025 •

edited

Loading

Uh oh!

nx-cloud bot commented Aug 27, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Aug 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 27, 2025 •

edited

Loading

🗃️ Groups

🛡️ Audits

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat(plugin-eslint): add artefact options #1089

feat(plugin-eslint): add artefact options #1089

Uh oh!

Conversation

BioPhoton commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BioPhoton commented Aug 27, 2025 •

edited

Loading

nx-cloud bot commented Aug 27, 2025 •

edited

Loading

pkg-pr-new bot commented Aug 27, 2025 •

edited

Loading

github-actions bot commented Aug 27, 2025 •

edited

Loading