Skip to content

feat(args): adding 'stdout' flag #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

jkellz-dev
Copy link
Contributor

Added a '--stdout' flag to output the message to stdout instead of continuing on with the git workflow. Allows koji to be used with non-git workflows.

Added a '--stdout' flag to output the message to stdout instead of continuing on with the git workflow. Allows koji to be used with non-git workflows.
The "stdout" does nothing in hook mode. Ensuring they are not called together.
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/lib/commit.rs 93.75% <100.00%> (+0.89%) ⬆️

Copy link
Owner

@cococonscious cococonscious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jonathan, thanks for your PR!
Please add two integration tests for the argument, one checking for success, the other for checking that it conflicts with all and hook correctly. Otherwise LGTM.

added tests checking for success as well as '--hook' and '--all' exclusion.
@cococonscious cococonscious enabled auto-merge (squash) January 21, 2025 15:02
@cococonscious cococonscious merged commit 38b7aff into cococonscious:main Jan 21, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
cococonscious pushed a commit that referenced this pull request Jan 21, 2025
## 🤖 New release
* `koji`: 3.1.0 -> 3.2.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[3.2.0](v3.1.0...v3.2.0) -
2025-01-21

### Added

- *(args)* adding 'stdout' flag (#129)

### Changed

- *(deps)* update rust crate dirs to v6 (#132)
- update all non-major dependencies (#130)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@cococonscious cococonscious mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants