Skip to content

Conversation

cococonscious
Copy link
Owner

closes #118

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/lib/answers.rs 100.00% <100.00%> (ø)
src/lib/config.rs 100.00% <100.00%> (+2.56%) ⬆️

@cococonscious cococonscious merged commit 46637f8 into main Dec 17, 2024
4 checks passed
@cococonscious cococonscious deleted the fix/userconfig branch December 17, 2024 13:01
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
cococonscious added a commit that referenced this pull request Jan 6, 2025
## 🤖 New release
* `koji`: 3.0.0 -> 3.1.0 

### ⚠️ `koji` breaking changes (irrelevant for users)

```
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field Config.workdir in /tmp/.tmp0qUV6w/koji/src/lib/config.rs:17

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/function_missing.ron

Failed in:
  function koji::questions::prompt_issue_text, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:243
  function koji::questions::prompt_issues, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:233
  function koji::questions::prompt_scope, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:114
  function koji::questions::prompt_type, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:98
  function koji::questions::prompt_breaking, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:204
  function koji::questions::prompt_body, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:185
  function koji::questions::prompt_summary, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:169
  function koji::questions::prompt_breaking_text, previously in file /tmp/.tmpGSN8WR/koji/src/lib/questions.rs:214

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/function_parameter_count_changed.ron

Failed in:
  koji::commit::commit now takes 2 parameters instead of 1, in /tmp/.tmp0qUV6w/koji/src/lib/commit.rs:35
  koji::answers::get_extracted_answers now takes 3 parameters instead of 2, in /tmp/.tmp0qUV6w/koji/src/lib/answers.rs:66
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[3.1.0](v3.0.0...v3.1.0) -
2025-01-06

### Added

- git-like -C argument, integration tests (#103)

### Changed

- *(deps)* update codecov/codecov-action action to v5.1.2 (#123, #116)
- *(deps)* update all non-major dependencies (#122, #112)
- *(deps)* update rust crate serde to v1.0.216 (#119)
- *(deps)* update actions/cache action to v4.2.0 (#113)

### Fixed

- *(args)* mutually exclusive hook and all (#121)
- *(config)* handled better using config-rs (#120)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Finley Thomalla <finley@thomalla.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

koji does not respect config in ~/.config/koji/config.toml
1 participant