This repository was archived by the owner on May 3, 2022. It is now read-only.
Bump cnab-go dep #804
Merged
Bump cnab-go dep #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyn
approved these changes
Jul 24, 2019
glyn
suggested changes
Jul 24, 2019
There was a problem hiding this comment.
It has come to my attention that some driver code was moved from duffle to cnab-go. I think we should delete the code as part of this bump PR so that we don't end up with the code in two places.
#809 covers this. Please see the note to implementers!
|
@glyn happy to do that as part of this PR! |
|
@glyn I've bumped to v0.2.1 in this PR (noticed a problem that wasn't caught in cnab-go) and have removed the drivers. There was some necessary updates to the test data in this PR because of the digest -> contentDigest change that came with v0.2.1. |
|
This also closes #809 |
glyn
approved these changes
Jul 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the cnab-go dependency and handles the breaking change to bundle.ValuesOrDefaults