Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.
This repository was archived by the owner on May 3, 2022. It is now read-only.

make build fails to compile pkg/driver/kubernetes.go #773

@glyn

Description

@glyn

Building (using docker) on macOS 10.14.5 fails, thus:

$ make build
docker run -it --rm -e SKIP_DOCKER=true -v /Users/gnormington/go/src/github.com/deislabs/duffle/:/go/src/github.com/deislabs/duffle -w /go/src/github.com/deislabs/duffle quay.io/deis/lightweight-docker-go:v0.7.0 bash -c "LDFLAGS=\"-w -s -X github.com/deislabs/duffle/pkg/version.Version=4dccb95\" scripts/build.sh"
building linux-amd64
# github.com/deislabs/duffle/pkg/driver
pkg/driver/kubernetes.go:350:10: undefined: strings.ReplaceAll
make: *** [build-all-bins] Error 2

Building locally works fine:

$ go version
go version go1.12.6 darwin/amd64
$ SKIP_DOCKER=true make build-darwin
bash -c "GOOS=darwin LDFLAGS=\"-w -s -X github.com/deislabs/duffle/pkg/version.Version=4dccb95\" scripts/build.sh"
building darwin-amd64

Note: strings.ReplaceAll was added last year here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions