Add description and stateless fields to action #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom actions lacked a description field. This fixed that. Also introduces stateless custom actions to implement things like `dry-run`, `help` etc. The docker-app tool currently abuse the spec to do this kind of things for the `inspect` and `render` actions, that are executed without passing credentials, and are used to visualize the effect of parameter values on the generated stack. Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
radu-matei
reviewed
Jan 31, 2019
radu-matei
reviewed
Jan 31, 2019
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
|
Thankis @radu-matei, fixed your comments, but mot sure yet if it is proper english :) |
radu-matei
pushed a commit
to cnabio/duffle
that referenced
this pull request
Mar 14, 2019
This implements stateless actions as defined in cnabio/cnab-spec#85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom actions lacked a description field. This fixed that. Also introduces stateless custom actions to implement things like
dry-run,helpetc.The docker-app tool currently abuse the spec to do this kind of things:
inspectandrenderactions are executed without passing credentials, and are used to visualize the effect of parameter values on the generated stack. We think it should be part of the standard as we see similar requirements for many other generic CNAB (Helm, Terraform, ...)