Skip to content

Fix Docker tag syntax #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix Docker tag syntax #785

merged 1 commit into from
Oct 5, 2022

Conversation

emcniece
Copy link
Contributor

@emcniece emcniece commented Oct 5, 2022

First attempt in #784 was broken:

0ac3c0fe: Preparing 
57fd6d7d: Preparing 
0ef44274: Preparing 
2ef10e9a: Preparing 
v1.9.28: digest: sha256:0ab6d82f48cfc3bfe6faf05dcef435e7a052910679bdb0f534267d4d45b3ca0b size: 1372
Error response from daemon: No such image: v1.9.28:latest

Exited with code exit status 1
CircleCI received exit code 1

This should fix the docker tag syntax.

MitchBradley
MitchBradley approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@MitchBradley MitchBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My docker knowledge is very shallow, but on the surface, this looks good.

@emcniece
Copy link
Contributor Author

emcniece commented Oct 5, 2022

For sanity's sake, here's an example of tagging actually working:

$ docker images
REPOSITORY       TAG          IMAGE ID       CREATED       SIZE
alpine           latest       a6215f271958   8 weeks ago   5.29MB


$ docker tag alpine:latest alpine:test-tag

$ docker images
REPOSITORY       TAG          IMAGE ID       CREATED       SIZE
alpine           latest       a6215f271958   8 weeks ago   5.29MB
alpine           test-tag     a6215f271958   8 weeks ago   5.29MB

The part I missed last time was using repo:tag instead of just tag. Thanks for the review :)

@emcniece emcniece merged commit 755c77b into cncjs:master Oct 5, 2022
@emcniece emcniece deleted the fix/docker-push-latest2 branch October 5, 2022 20:31
@emcniece
Copy link
Contributor Author

emcniece commented Oct 5, 2022

Success!

docker pull cncjs/cncjs
Using default tag: latest
latest: Pulling from cncjs/cncjs
f606d8928ed3: Pull complete
1f34ee6937ae: Pull complete
f2c875846028: Pull complete
60fef9cf4d89: Pull complete
cdfbb6dc4fca: Pull complete
Digest: sha256:304a41f8f178a08ee4aad7cd8a55399a38b038a8ab702e61949b20f57193b003
Status: Downloaded newer image for cncjs/cncjs:latest
docker.io/cncjs/cncjs:latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchBradley MitchBradley MitchBradley approved these changes

@cheton cheton Awaiting requested review from cheton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emcniece @MitchBradley