Add extension point to StringMatcher #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Greenway <ggreenway@apple.com>
e7fe7cf to
998656c
Compare
|
@mmorel-35 Could the changes in #85 cause the CI error? |
|
I believe that the CI is saying that the golang hasn't been updated after the modification of the protobuf. Am I misreading it ? |
I don't remember that we needed to that previously. I wonder what triggered the need for #85. I guess it could be a prior PR, but want to make sure that everything is aligned. |
Signed-off-by: Greg Greenway <ggreenway@apple.com>
b08e822 to
d3cd380
Compare
|
Ah, I see in DEVOLPER.md the steps I needed to regenerate those files |
i think this always been the case |
|
Ack, thanks @mmorel-35 and @phlax! apologies for the unneeded ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the change made in envoyproxy/envoy#32586