fix hub panic due to changed dependencies #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested locally. Worked as expected. cc @abstractmj @levidehaan Please help verify this PR. Thanks. |
Signed-off-by: Di Xu <stephenhsu90@gmail.com>
125856f to
04cdbfe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
+ Coverage 13.60% 13.87% +0.27%
==========================================
Files 66 77 +11
Lines 7492 9087 +1595
==========================================
+ Hits 1019 1261 +242
- Misses 6391 7729 +1338
- Partials 82 97 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@abstractmj @levidehaan Any feedbacks on this PR? I am going to release v0.17.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/bug
What this PR does / why we need it:
This bug only existed in v0.17.0 and v0.17.1
Which issue(s) this PR fixes:
Fixes #816
Special notes for your reviewer: