Skip to content

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Dec 18, 2024

What type of PR is this?

kind/bug

What this PR does / why we need it:

cherry pick #840

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Di Xu <stephenhsu90@gmail.com>
@dixudx dixudx added the kind/bug Something isn't working label Dec 18, 2024
@dixudx dixudx added this to the v0.17.3 milestone Dec 18, 2024
@dixudx dixudx requested a review from a team as a code owner December 18, 2024 06:59
@dixudx dixudx requested review from yiwei-C and removed request for a team December 18, 2024 06:59
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-0.17@4cef311). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/hub/options/options.go 0.00% 2 Missing ⚠️
pkg/hub/registry/proxies/socket/rest.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release-0.17    #848   +/-   ##
==============================================
  Coverage                ?   6.45%           
==============================================
  Files                   ?     269           
  Lines                   ?   27711           
  Branches                ?       0           
==============================================
  Hits                    ?    1789           
  Misses                  ?   25776           
  Partials                ?     146           
Flag Coverage Δ
unittests 6.45% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dixudx dixudx merged commit 5b159d6 into clusternet:release-0.17 Dec 18, 2024
8 checks passed
@dixudx dixudx deleted the cherry-pick-840 branch December 18, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant