fix pruning obsolete feeds when running in pull mode #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixudx
reviewed
Jun 15, 2023
| } | ||
|
|
||
| // creating credentials to parent cluster is also required in the pull mode, | ||
| // because the cleaning of redundant objects in the description is performed in the hub |
There was a problem hiding this comment.
s/hub/clusternet-controller-manager
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #711 +/- ##
==========================================
- Coverage 13.60% 12.96% -0.64%
==========================================
Files 66 76 +10
Lines 7492 8710 +1218
==========================================
+ Hits 1019 1129 +110
- Misses 6391 7497 +1106
- Partials 82 84 +2 |
dixudx
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/bug
fix feed leak when agent is in pull mode
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #710
Special notes for your reviewer: