Skip to content

Conversation

abstractmj
Copy link
Contributor

@abstractmj abstractmj commented Dec 28, 2023

xref #763

@abstractmj abstractmj requested review from a team as code owners December 28, 2023 09:43
@abstractmj abstractmj requested a review from yiwei-C December 28, 2023 09:43
@dixudx dixudx added this to the v0.17.0 milestone Dec 29, 2023
@dixudx dixudx added kind/feature New feature or request kind/apis APIs releated labels Dec 29, 2023
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please fix the CI.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2ffa5f) 13.60% compared to head (bbc023a) 14.09%.
Report is 132 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
+ Coverage   13.60%   14.09%   +0.48%     
==========================================
  Files          66       79      +13     
  Lines        7492     9091    +1599     
==========================================
+ Hits         1019     1281     +262     
- Misses       6391     7713    +1322     
- Partials       82       97      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dixudx dixudx changed the title feature: add PostAssign stage into scheduler framework; issue #763 add PostAssign stage into scheduler framework Dec 29, 2023
@dixudx dixudx merged commit 1bafec0 into clusternet:main Dec 29, 2023
zhenkuang pushed a commit to zhenkuang/clusternet that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/apis APIs releated kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants