Skip to content

Conversation

stpolar
Copy link
Contributor

@stpolar stpolar commented Nov 29, 2023

…wn event

What type of PR is this?

bug fix

What this PR does / why we need it:

agent crash

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

fix agent crash when resource informer receive DeletedFinalStateUnknown event.

agent-crash

…wn event

Signed-off-by: polarwu <polarwu@tencent.com>
@stpolar stpolar requested a review from a team as a code owner November 29, 2023 03:21
@stpolar stpolar requested a review from yiwei-C November 29, 2023 03:21
@dixudx dixudx added this to the v0.17.0 milestone Nov 29, 2023
@dixudx dixudx added the kind/bug Something isn't working label Nov 29, 2023
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Good work!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2ffa5f) 13.60% compared to head (45ab654) 13.08%.
Report is 124 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
- Coverage   13.60%   13.08%   -0.52%     
==========================================
  Files          66       78      +12     
  Lines        7492     8859    +1367     
==========================================
+ Hits         1019     1159     +140     
- Misses       6391     7614    +1223     
- Partials       82       86       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dixudx dixudx changed the title fix agent crash when resource informer receive DeletedFinalStateUnkno… fix type assertion when receiving DeletedFinalStateUnknown event Nov 29, 2023
@dixudx dixudx merged commit 8dd24e5 into clusternet:main Nov 29, 2023
zhenkuang pushed a commit to zhenkuang/clusternet that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants