Skip to content

Conversation

jay376
Copy link
Contributor

@jay376 jay376 commented Apr 14, 2023

What type of PR is this?

kind/bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #665

Special notes for your reviewer:

@jay376 jay376 requested a review from a team as a code owner April 14, 2023 07:26
@jay376 jay376 requested a review from dixudx April 14, 2023 07:26
@dixudx dixudx added this to the v0.16.0 milestone Apr 17, 2023
@dixudx dixudx added the kind/bug Something isn't working label Apr 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #667 (c311057) into main (e2ffa5f) will decrease coverage by 0.23%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   13.60%   13.37%   -0.23%     
==========================================
  Files          66       71       +5     
  Lines        7492     7740     +248     
==========================================
+ Hits         1019     1035      +16     
- Misses       6391     6621     +230     
- Partials       82       84       +2     

see 38 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: zhangfangjie <f22jay@gmail.com>
@jay376 jay376 force-pushed the fix-validate-token branch from 0b0c5e1 to c311057 Compare April 17, 2023 02:15
Copy link
Member

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution.

Welcome to the community. 🎉🎉🎉

@dixudx dixudx merged commit e156bf0 into clusternet:main Apr 17, 2023
@jay376 jay376 deleted the fix-validate-token branch April 17, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clusternet-agent crashed when using serviceaccount token for bootstrapping
3 participants