Installed and upgraded to PHPUnit 7.5. #84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Literally all of the tests always pass on my box. I wonder if this is a TravisCI edge case? I even compiled PHP 7.3.2 with ZTS to ensure that it wasn't that. |
|
@hopeseekr Thank you very much for looking into this and for your patience! I've just merged #85 which adds PHPUnit and also fixes the race condition you've observed on Travis. I also couldn't reproduce this locally, but with the provided patch this now works in 5/5 runs even after rerunning the tests a couple of times. This project is currently locked to support PHP 5.3, so we have to stick to legacy PHPUnit 4 for now. Thank you for your input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is