Skip to content

Conversation

crussell52
Copy link

Addresses issue #21

@@ -34,7 +34,7 @@ public function getPsr0()

$resources = array();
foreach ($this->autoload['psr-0'] as $namespace => $paths) {
foreach($this->correctSinglePath($paths) as $path) {
foreach((array)$paths as $path) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified this trivial operation. Instead of a private method, this is now simply an array cast.

@hopeseekr
Copy link

After 3 1/2 years, I have merged this into my new fork of phar-composer. Thank you! I will be releasing it relatively soon.

@clue
Copy link
Owner

clue commented Nov 12, 2019

@crussell52 Thank you for looking into this, providing this high-quality PR and for your patience! 👍 Your changes make perfect sense with the issues that were opened at the time you've filed this excellent PR. I've recently set up a new roadmap (#88) for future development and just superseded this PR by removing much of the related logic via #92, so that any explicit autoload logic is no longer needed.

I'll assume this is resolved and will close this for now, please feel free to report back otherwise 👍 Again, thank you for your contribution and keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants