Refactor the autoload process in the bin script. #18
Conversation
|
Thanks for your PR, @nubs 👍 I agree it makes sense to refactor this part and this change makes for a much cleaner code which is much easier to understand. That being said, I personally feel looping over an array of possible file paths is a bit overkill. I would suggest using a normal conditional statement like this. Any thoughts? |
|
I prefer the |
This is a bit easier to understand I think. It also uses require rather than include, so that failure to properly load the file terminates the script. It also removes the error suppression which can silence unwanted errors (It will silence any errors that occur while parsing the related class (and any other files included in the process)).
|
Okay, I updated it using the linked code. I dislike the repeated path strings, but agree that a foreach loop is also kinda silly (especially since the list of paths isn't likely to grow anytime soon). |
|
Thanks for the feedback @lyrixx and thanks for the updated PR @nubs! I agree that the duplicated path strings aren't quite ideal either. Tbh, personally, I don't think this is actually worth any further effort :) So until anybody comes up with a better solution, I think we're save to merge this as-is. Thanks guys, keep it up 👍 |
Refactor the autoload process in the bin script.
|
We use to see this too: if (file_exists($file = __DIR__ . '/../vendor/autoload.php')) {
require $file
} elseif (file_exists($file = __DIR__ . '/../../../autoload.php')) {
require $file
} else {
fwrite(STDERR, 'ERROR: Composer dependencies not properly set up! Run "composer install" or see README.md for more details' . PHP_EOL);
exit(1);
} |
|
I ran into this issue using the latest tag, per installation instructions. Maybe create a new tag and let Packagist update? |
Thanks for your patience, finally done |
This is a bit easier to understand I think.
It also uses require rather than include, so that failure to properly load the file terminates the script.
It also removes the error suppression which can silence unwanted errors (It will silence any errors that occur while parsing the related class (and any other files included in the process)).