Skip to content

Add Search for a composer autoload file when installed using Composer #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2014

Conversation

elkuku
Copy link
Contributor

@elkuku elkuku commented Jan 15, 2014

Hi,
I just tried installing graph-composer using Composer - an option which is not even mentioned in then install documentation, but which is doing pretty well.
Unfortunately graph-composer isn't prepared for that case (yet), so this is how it might be fixed.

@clue
Copy link
Owner

clue commented Jan 15, 2014

Thanks! The changes look good to me and I'm looking forward to merge them soon.

an option which is not even mentioned in then install documentation

Would you care to add it to the README? :) Also, perhaps providing some rationale as to why/when to install via composer would be much appreciated.

Thanks!

Add "Installation using Composer"
@elkuku
Copy link
Contributor Author

elkuku commented Jan 16, 2014

Well, TBH, actually I'm not quite sure if what I am proposing here makes sense at all...

A use case might be if you want to hack the graph-composer code to fit a particular project.
Also - installation is "cheap" (just adiing graph-composer to the composer.json file).
Updates may (or may not) be easier running composer update.

Looking at your other projects related to Composer, phars and stuff, it seems that you know when to recommend a phar installation so, feel free not to merge this if it's not useful.

@temp
Copy link

temp commented Mar 12, 2014

Any news here?
Just installed it via composer, and it does not work out of the box:

$ graph-composer
ERROR: Composer not properly set up! Run "composer install" or see README.md for more details

@clue clue merged commit 40a2ddf into clue:master Mar 22, 2014
@clue
Copy link
Owner

clue commented Mar 22, 2014

Thanks @elkuku, I've finally merged this feature and am looking towards releasing it with a v0.2.0 eventually 👍

Also, I've streamlined the readme a fair bit and added a remark to the changelog. As much as I encourage automating common tasks, I'd rather try to not prefer a single tool (Apache Ant) in the readme. Nontheless your input has proven valuable in communicating your usecase, so I really appreciate your input!

@elkuku elkuku deleted the composer-install branch April 14, 2014 23:36
@elkuku
Copy link
Contributor Author

elkuku commented Apr 14, 2014

Has been a pleasure 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants