optimize: go net implementation #1788

ppzqh · 2025-06-06T03:13:14Z

What type of PR is this?

optimize

Check the PR title.

This PR title match the format: <type>(optional scope): <description>
The description of this PR title is user-oriented and clear enough for others to understand.
Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

codecov · 2025-06-06T03:14:17Z

Codecov Report

Attention: Patch coverage is 51.18483% with 103 lines in your changes missing coverage. Please review.

Project coverage is 60.45%. Comparing base (07c5078) to head (6073dde).
Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
internal/mocks/bufiox/bufreader.go	0.00%	57 Missing ⚠️
pkg/remote/trans/gonet/conn.go	44.44%	20 Missing ⚠️
internal/mocks/transhandlerserver.go	0.00%	8 Missing ⚠️
pkg/remote/trans/gonet/trans_server.go	90.76%	4 Missing and 2 partials ⚠️
pkg/remote/trans/gonet/bytebuffer.go	78.26%	4 Missing and 1 partial ⚠️
pkg/remote/trans/gonet/dialer.go	0.00%	5 Missing ⚠️
internal/mocks/conn.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1788      +/-   ##
===========================================
+ Coverage    60.38%   60.45%   +0.07%     
===========================================
  Files          379      381       +2     
  Lines        34438    34515      +77     
===========================================
+ Hits         20795    20867      +72     
+ Misses       12381    12378       -3     
- Partials      1262     1270       +8

Flag	Coverage Δ
integration	`48.28% <0.00%> (+0.02%)`	⬆️
unit	`50.84% <51.18%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pkg/remote/trans/gonet/conn_extension.go

pkg/remote/trans/gonet/conn.go

pkg/remote/codec/thrift/codec_apache.go

pkg/remote/trans/gonet/bytebuffer.go

pkg/remote/trans/gonet/trans_server.go

ppzqh requested review from a team as code owners June 6, 2025 03:13

ppzqh marked this pull request as draft June 6, 2025 03:13

ppzqh force-pushed the optimize-gonet branch from b21a3f8 to 00727b7 Compare June 6, 2025 03:48

ppzqh commented Jun 6, 2025

View reviewed changes

pkg/remote/trans/gonet/conn_extension.go Outdated Show resolved Hide resolved

ppzqh force-pushed the optimize-gonet branch 5 times, most recently from fbe90b2 to e1d1a09 Compare June 9, 2025 09:00

ppzqh marked this pull request as ready for review June 9, 2025 09:01

ppzqh force-pushed the optimize-gonet branch 2 times, most recently from b424dff to 3f66d06 Compare June 10, 2025 06:54

optimize: go net implementation

b29aa2c

ppzqh force-pushed the optimize-gonet branch from 3f66d06 to b29aa2c Compare June 10, 2025 06:55

chore: add comments for ReadableLen

2789d2c