Skip to content

feat(ttstream): process MetaFrame and reflect to rpcinfo #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DMwangnima
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat(ttstream): 解析 MetaFrame 并将相关元信息反应到 rpcinfo

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners May 30, 2025 03:43
@DMwangnima DMwangnima force-pushed the feat/ttstream_meta_handler branch from 0aa48ad to 252766e Compare May 30, 2025 03:47
@DMwangnima DMwangnima marked this pull request as draft May 30, 2025 03:48
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.06%. Comparing base (b36d010) to head (6d7021a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/remote/trans/ttstream/client_provider.go 40.00% 2 Missing and 1 partial ⚠️
pkg/remote/trans/ttstream/transport.go 50.00% 2 Missing and 1 partial ⚠️
pkg/remote/trans/ttstream/test_utils.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1782      +/-   ##
===========================================
+ Coverage    59.94%   60.06%   +0.11%     
===========================================
  Files          381      380       -1     
  Lines        34660    34635      -25     
===========================================
+ Hits         20778    20803      +25     
+ Misses       12621    12575      -46     
+ Partials      1261     1257       -4     
Flag Coverage Δ
integration 48.25% <35.29%> (+0.13%) ⬆️
unit 50.44% <47.05%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DMwangnima DMwangnima force-pushed the feat/ttstream_meta_handler branch 2 times, most recently from 61e2a53 to 1c04dd5 Compare May 30, 2025 12:23
@DMwangnima DMwangnima marked this pull request as ready for review May 30, 2025 12:39
@DMwangnima DMwangnima force-pushed the feat/ttstream_meta_handler branch 3 times, most recently from 1d74ea9 to b02a506 Compare June 5, 2025 09:25
@DMwangnima DMwangnima marked this pull request as draft June 5, 2025 09:26
@DMwangnima DMwangnima force-pushed the feat/ttstream_meta_handler branch from b02a506 to ddfb2ae Compare June 5, 2025 09:33
@DMwangnima DMwangnima marked this pull request as ready for review June 5, 2025 12:11
@DMwangnima DMwangnima force-pushed the feat/ttstream_meta_handler branch from ddfb2ae to 6d7021a Compare June 6, 2025 04:01
@DMwangnima DMwangnima merged commit 62475fe into cloudwego:develop Jun 6, 2025
21 of 22 checks passed
@DMwangnima DMwangnima deleted the feat/ttstream_meta_handler branch June 6, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants