Skip to content

chore: remove testify dependency #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

chore: remove testify dependency #1776

merged 1 commit into from
May 15, 2025

Conversation

yqaty
Copy link
Contributor

@yqaty yqaty commented May 15, 2025 •
edited
Loading

Change-Id: I18e0ca6f75da7e992691b5996ca677270f366b36

What type of PR is this?

chore

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@codecov Codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.76%. Comparing base (18b685d) to head (395536a).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1776      +/-   ##
===========================================
- Coverage    59.80%   59.76%   -0.04%     
===========================================
  Files          382      382              
  Lines        34594    34594              
===========================================
- Hits         20689    20676      -13     
- Misses       12645    12655      +10     
- Partials      1260     1263       +3
Flag Coverage Δ
integration 47.90% <ø> (-0.08%) ⬇️
unit 50.02% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yqaty
chore: remove testify dependency
395536a 
Change-Id: I18e0ca6f75da7e992691b5996ca677270f366b36
@yqaty yqaty force-pushed the chore/remove_testify branch from 0484727 to 395536a Compare May 15, 2025 03:29
@yqaty yqaty marked this pull request as ready for review May 15, 2025 03:31
@yqaty yqaty requested review from a team as code owners May 15, 2025 03:31
@jayantxie jayantxie merged commit 7c4ae57 into cloudwego:develop May 15, 2025
21 of 22 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantxie jayantxie jayantxie approved these changes

@HeyJavaBean HeyJavaBean HeyJavaBean approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yqaty @jayantxie @HeyJavaBean