Skip to content

fix(server): trans server conn count race issue #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

fix(server): trans server conn count race issue #1774

merged 1 commit into from
May 6, 2025

Conversation

jayantxie
Copy link
Member

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners May 6, 2025 08:34
@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.76%. Comparing base (01e60a0) to head (98cd963).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/remote/trans/gonet/trans_server.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1774      +/-   ##
===========================================
- Coverage    59.77%   59.76%   -0.02%     
===========================================
  Files          382      382              
  Lines        34595    34595              
===========================================
- Hits         20680    20676       -4     
- Misses       12657    12658       +1     
- Partials      1258     1261       +3
Flag Coverage Δ
integration 47.84% <0.00%> (+0.07%) ⬆️
unit 50.11% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayantxie jayantxie changed the title fix(server): conn count race issue fix(server): trans server conn count race issue May 6, 2025
@jayantxie jayantxie merged commit 9f10edd into cloudwego:develop May 6, 2025
20 of 22 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsterDY AsterDY AsterDY approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayantxie @AsterDY @DMwangnima