Skip to content

refactor: refactor generic streaming #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

refactor: refactor generic streaming #1770

merged 3 commits into from
May 28, 2025

Conversation

yqaty
Copy link
Contributor

@yqaty yqaty commented Apr 24, 2025

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@yqaty yqaty force-pushed the refactor/refactor_generic_streaming branch from bb1f79f to eea8296 Compare April 24, 2025 07:55
@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 59.92%. Comparing base (7a3b4e9) to head (ed50cc0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
client/genericclient/client.go 80.18% 14 Missing and 7 partials ⚠️
client/genericclient/stream.go 93.93% 2 Missing ⚠️
client/genericclient/generic_stream_service.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1770      +/-   ##
===========================================
+ Coverage    59.77%   59.92%   +0.15%     
===========================================
  Files          382      381       -1     
  Lines        34622    34617       -5     
===========================================
+ Hits         20696    20745      +49     
+ Misses       12661    12623      -38     
+ Partials      1265     1249      -16
Flag Coverage Δ
integration 48.01% <88.00%> (+<0.01%) ⬆️
unit 50.16% <9.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yqaty yqaty force-pushed the refactor/refactor_generic_streaming branch 4 times, most recently from 2f387f5 to b6129b3 Compare April 24, 2025 08:38
jayantxie
jayantxie reviewed Apr 24, 2025
View reviewed changes
@yqaty yqaty force-pushed the refactor/refactor_generic_streaming branch 6 times, most recently from 69e47c5 to bc3974a Compare April 25, 2025 08:24
jayantxie
jayantxie reviewed Apr 25, 2025
View reviewed changes
@yqaty yqaty force-pushed the refactor/refactor_generic_streaming branch 6 times, most recently from a0a2290 to e941a24 Compare April 27, 2025 07:04
jayantxie
jayantxie reviewed Apr 27, 2025
View reviewed changes
jayantxie
jayantxie reviewed Apr 27, 2025
View reviewed changes
jayantxie
jayantxie reviewed Apr 27, 2025
View reviewed changes
@yqaty yqaty force-pushed the refactor/refactor_generic_streaming branch 3 times, most recently from 4ca9e0d to 7ea74c3 Compare April 27, 2025 08:06
jayantxie
jayantxie previously approved these changes Apr 27, 2025
View reviewed changes
@yqaty yqaty force-pushed the refactor/refactor_generic_streaming branch from 7ea74c3 to 37ca3d3 Compare April 27, 2025 08:56
DMwangnima
DMwangnima reviewed Apr 27, 2025
View reviewed changes
@yqaty yqaty force-pushed the refactor/refactor_generic_streaming branch from 37ca3d3 to 9f04521 Compare April 27, 2025 09:45
@yqaty yqaty force-pushed the refactor/refactor_generic_streaming branch from 9f04521 to 25ac713 Compare May 23, 2025 03:16
jayantxie
jayantxie previously approved these changes May 27, 2025
View reviewed changes
DMwangnima
DMwangnima previously approved these changes May 27, 2025
View reviewed changes
yqaty added 3 commits May 28, 2025 11:08
@yqaty
docs: add comments to binarypb and streamx
f75ad6c 
Change-Id: I2ee2de474f725173518cd594ad013cb03baa1b99
@yqaty
refactor: refactor generic streaming
292529d 
Change-Id: Ia93b6d3228ace8d01fd51f6fc264d20a4cd6c33c
@yqaty
feat: binarypb add extra field
ed50cc0 
Change-Id: I16d3cfbeb04c25b7f84415cd3be9bbfafc8cd063
@yqaty yqaty dismissed stale reviews from DMwangnima and jayantxie via ed50cc0 May 28, 2025 03:09
@yqaty yqaty force-pushed the refactor/refactor_generic_streaming branch from 25ac713 to ed50cc0 Compare May 28, 2025 03:09
@yqaty yqaty requested review from jayantxie and DMwangnima May 28, 2025 03:18
@yqaty yqaty marked this pull request as ready for review May 28, 2025 03:18
@yqaty yqaty requested review from a team as code owners May 28, 2025 03:18
@jayantxie jayantxie merged commit c5d41fa into cloudwego:develop May 28, 2025
22 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantxie jayantxie jayantxie approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yqaty @jayantxie @DMwangnima