Skip to content

feat(generic): support generic pb binary for streaming #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2025
Merged

feat(generic): support generic pb binary for streaming #1752

merged 4 commits into from
Apr 11, 2025
+248 −3

Conversation

yqaty
Copy link
Contributor

@yqaty yqaty commented Apr 8, 2025 •
edited
Loading

Change-Id: If8b2ddd99bf282d2be18d9fde9d76006d294a45c

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • [] Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@yqaty yqaty requested review from a team as code owners April 8, 2025 14:05
@yqaty yqaty changed the title feat(generic): support generic pb binary for streaming [WIP] feat(generic): support generic pb binary for streaming Apr 9, 2025
@yqaty yqaty force-pushed the feat/generic_pb_binary branch 4 times, most recently from 48c1f13 to 0f08986 Compare April 9, 2025 08:27
@yqaty yqaty changed the title [WIP] feat(generic): support generic pb binary for streaming feat(generic): support generic pb binary for streaming Apr 9, 2025
@yqaty yqaty force-pushed the feat/generic_pb_binary branch from 0f08986 to 75421e2 Compare April 10, 2025 03:58
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.58%. Comparing base (b7c9549) to head (c1f960c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/generic/generic.go 89.47% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1752      +/-   ##
===========================================
+ Coverage    59.25%   59.58%   +0.32%     
===========================================
  Files          379      381       +2     
  Lines        34449    34486      +37     
===========================================
+ Hits         20413    20548     +135     
+ Misses       12804    12681     -123     
- Partials      1232     1257      +25
Flag Coverage Δ
integration 47.48% <90.00%> (+0.69%) ⬆️
unit 50.15% <45.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yqaty yqaty force-pushed the feat/generic_pb_binary branch 5 times, most recently from a0ebeba to fb04ed6 Compare April 10, 2025 07:24
HeyJavaBean
HeyJavaBean reviewed Apr 10, 2025
View reviewed changes
@yqaty yqaty force-pushed the feat/generic_pb_binary branch from fb04ed6 to db14fa1 Compare April 10, 2025 07:36
@yqaty yqaty marked this pull request as draft April 11, 2025 03:13
@yqaty yqaty force-pushed the feat/generic_pb_binary branch 2 times, most recently from 0811c00 to 877369e Compare April 11, 2025 03:27
jayantxie
jayantxie reviewed Apr 11, 2025
View reviewed changes
jayantxie
jayantxie reviewed Apr 11, 2025
View reviewed changes
@yqaty yqaty force-pushed the feat/generic_pb_binary branch from 877369e to a7cfb6a Compare April 11, 2025 03:47
jayantxie
jayantxie reviewed Apr 11, 2025
View reviewed changes
@yqaty yqaty force-pushed the feat/generic_pb_binary branch 2 times, most recently from d7482c8 to 3c76c1a Compare April 11, 2025 04:11
@yqaty yqaty marked this pull request as ready for review April 11, 2025 06:03
jayantxie
jayantxie reviewed Apr 11, 2025
View reviewed changes
@yqaty yqaty marked this pull request as draft April 11, 2025 06:09
@yqaty yqaty force-pushed the feat/generic_pb_binary branch 2 times, most recently from 4444674 to eb626ad Compare April 11, 2025 06:21
yqaty added 3 commits April 11, 2025 14:24
@yqaty
feat(generic): support generic pb binary for streaming
ed6c22e 
Change-Id: Ic5a3c8cf3d59c0157448cd956ff2058ad09d48a8
@yqaty
test: add raw_test.go
b8f2989 
Change-Id: I21d92a120277a8cf1c01e61d6ec7f5b9ddba753f
@yqaty
test: add binarypb_codec_test.go
059982d 
Change-Id: I5dcda137c230d8f27ab0bdea2c34542a72ed5354
@yqaty yqaty force-pushed the feat/generic_pb_binary branch from eb626ad to 059982d Compare April 11, 2025 06:24
@yqaty yqaty marked this pull request as ready for review April 11, 2025 06:39
@jayantxie jayantxie merged commit e9da611 into cloudwego:develop Apr 11, 2025
22 checks passed
yqaty added a commit to yqaty/kitex that referenced this pull request Apr 17, 2025
@yqaty
Revert "feat(generic): support generic pb binary for streaming (cloud…
0bf2064 
…wego#1752)"

This reverts commit e9da611.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantxie jayantxie jayantxie approved these changes

@HeyJavaBean HeyJavaBean HeyJavaBean approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yqaty @jayantxie @HeyJavaBean