fix(gRPC): task of cleaning up canceled streams in http2Client has a probability of deadlocking #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1747 +/- ##
===========================================
+ Coverage 59.11% 59.15% +0.03%
===========================================
Files 379 379
Lines 34432 34438 +6
===========================================
+ Hits 20356 20373 +17
+ Misses 12840 12829 -11
Partials 1236 1236
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7585782 to
1aa535c
Compare
1aa535c to
36e6549
Compare
jayantxie
approved these changes
Apr 7, 2025
ppzqh
approved these changes
Apr 7, 2025
DMwangnima
added a commit
to DMwangnima/kitex
that referenced
this pull request
Apr 8, 2025
…probability of deadlocking (cloudwego#1747)
DMwangnima
added a commit
to DMwangnima/kitex
that referenced
this pull request
Apr 8, 2025
…probability of deadlocking (cloudwego#1747)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
fix(gRPC): http2Client 中清理 cancel 流的任务有概率死锁
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: