-
Notifications
You must be signed in to change notification settings - Fork 886
fix(generic): align dynamicgo's write base behavior with old generic (only for internal logic) #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1742 +/- ##
===========================================
+ Coverage 59.23% 59.35% +0.12%
===========================================
Files 379 379
Lines 34438 34449 +11
===========================================
+ Hits 20398 20447 +49
+ Misses 12813 12779 -34
+ Partials 1227 1223 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a56dd8b
to
d625d13
Compare
jayantxie
previously approved these changes
Mar 26, 2025
d625d13
to
65852ea
Compare
65852ea
to
6d173c6
Compare
jayantxie
approved these changes
Apr 10, 2025
YangruiEmma
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: dynamicgo-generic aligns merging-base behavior with old kitex-generic (
thrift-base
is only the historical implementation of metainfo inside the ByteDance, open-source users do not need to care)zh(optional): dynamicgo 泛化调用对齐 老版本泛化 中 合并框架与json中base 的行为(thrift base仅为字节跳动内部历史定义的元信息,开源用户无需关心)
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: