Skip to content

refactor(tool): move pb tpl code to sep pkg #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

refactor(tool): move pb tpl code to sep pkg #1729

merged 1 commit into from
Mar 12, 2025

Conversation

xiaost
Copy link
Collaborator

@xiaost xiaost commented Mar 11, 2025

What type of PR is this?

refactor

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

refactor(tool): 把 pb 的模版代码移到单独的包

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners March 11, 2025 10:51
@xiaost xiaost force-pushed the tool-pb-tpl branch 2 times, most recently from dfcda7c to e8a2e5f Compare March 11, 2025 10:52
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.79%. Comparing base (4335e89) to head (c5a9394).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1729      +/-   ##
===========================================
- Coverage    63.85%   63.79%   -0.06%     
===========================================
  Files          379      379              
  Lines        34310    34310              
===========================================
- Hits         21909    21889      -20     
- Misses       11092    11107      +15     
- Partials      1309     1314       +5
Flag Coverage Δ
integration 47.59% <ø> (-0.16%) ⬇️
unit 55.61% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost force-pushed the tool-pb-tpl branch 2 times, most recently from 088944a to 378caee Compare March 11, 2025 11:03
HeyJavaBean
HeyJavaBean reviewed Mar 11, 2025
View reviewed changes
HeyJavaBean
HeyJavaBean previously approved these changes Mar 11, 2025
View reviewed changes
@xiaost xiaost merged commit 25694d9 into cloudwego:develop Mar 12, 2025
21 of 22 checks passed
@xiaost xiaost deleted the tool-pb-tpl branch March 12, 2025 02:51
@BrewTestBot BrewTestBot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantxie jayantxie jayantxie approved these changes

@DMwangnima DMwangnima DMwangnima approved these changes

@HeyJavaBean HeyJavaBean HeyJavaBean approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaost @jayantxie @DMwangnima @HeyJavaBean