Skip to content

optimize(apache): remove apache codec gen and set default protocol from buffered to framed #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2025
Merged

optimize(apache): remove apache codec gen and set default protocol from buffered to framed #1728

merged 4 commits into from
Mar 13, 2025

Conversation

HeyJavaBean
Copy link
Member

@HeyJavaBean HeyJavaBean commented Mar 11, 2025 •
edited
Loading

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

optimize(apache): kitex 不再生成 apache codec 编解码产物，并且将默认协议从 buffered 设置为 framed

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
Additional Notes:

  1. Adjusted the corresponding unit tests.
  2. Upgraded thriftgo to fix a minor bug in the streamx scenario for integration testing.

zh(optional):
额外说明：

  1. 调整了对应的单测
  2. 升级 thriftgo 解决 streamx 场景的一个小bug，以便通过集成测试

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@HeyJavaBean HeyJavaBean requested review from a team as code owners March 11, 2025 09:31
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_codec_gen branch 4 times, most recently from 581abb7 to 3ec70c2 Compare March 11, 2025 12:54
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.76%. Comparing base (d262a8c) to head (0ea6a5d).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1728      +/-   ##
===========================================
- Coverage    63.84%   63.76%   -0.09%     
===========================================
  Files          379      379              
  Lines        34327    34328       +1     
===========================================
- Hits         21916    21889      -27     
- Misses       11099    11128      +29     
+ Partials      1312     1311       -1
Flag Coverage Δ
integration 47.20% <100.00%> (-0.40%) ⬇️
unit 55.67% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_codec_gen branch 2 times, most recently from 30ddd1e to abff92e Compare March 11, 2025 13:51
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_codec_gen branch from abff92e to 21ab248 Compare March 11, 2025 13:54
@HeyJavaBean HeyJavaBean changed the title optimize(apache): remove apache codec gen and set default protocol from buffered to framed [WIP]optimize(apache): remove apache codec gen and set default protocol from buffered to framed Mar 12, 2025
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_codec_gen branch from d024f3e to 7ea3822 Compare March 12, 2025 12:14
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_codec_gen branch from 7ea3822 to 01480b4 Compare March 12, 2025 12:26
@HeyJavaBean HeyJavaBean changed the title [WIP]optimize(apache): remove apache codec gen and set default protocol from buffered to framed optimize(apache): remove apache codec gen and set default protocol from buffered to framed Mar 12, 2025
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_codec_gen branch 5 times, most recently from 5f82d6c to d03239f Compare March 13, 2025 03:44
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_codec_gen branch from d03239f to 9dff4dd Compare March 13, 2025 03:54
HeyJavaBean
HeyJavaBean commented Mar 13, 2025
View reviewed changes
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_codec_gen branch 4 times, most recently from afe4083 to 29f6d1e Compare March 13, 2025 13:12
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_codec_gen branch 5 times, most recently from 0ea6a5d to 9dff4dd Compare March 13, 2025 14:20
@HeyJavaBean HeyJavaBean merged commit 4031e2a into cloudwego:develop Mar 13, 2025
41 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@jayantxie jayantxie jayantxie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeyJavaBean @YangruiEmma @jayantxie