Skip to content

fix: code gen import issue for streamx mode, stream call judgement bug and set ttheader streaming as default #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 12, 2025
Merged

fix: code gen import issue for streamx mode, stream call judgement bug and set ttheader streaming as default #1725

merged 5 commits into from
Mar 12, 2025

Conversation

jayantxie
Copy link
Member

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners March 11, 2025 06:37
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (efe7463) to head (86a3da4).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/remote/remotecli/stream.go 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1725      +/-   ##
===========================================
+ Coverage    63.73%   63.78%   +0.04%     
===========================================
  Files          379      379              
  Lines        34319    34348      +29     
===========================================
+ Hits         21874    21909      +35     
- Misses       11125    11130       +5     
+ Partials      1320     1309      -11
Flag Coverage Δ
integration 47.69% <93.10%> (+<0.01%) ⬆️
unit 55.81% <79.31%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayantxie jayantxie changed the title fix: code gen import issue for streamx mode fix: code gen import issue for streamx mode, stream call judgement and set ttheader streaming as default Mar 12, 2025
@jayantxie jayantxie force-pushed the fix/streamx_import_issue branch 2 times, most recently from 40acaf6 to e9012f3 Compare March 12, 2025 03:51
@jayantxie jayantxie force-pushed the fix/streamx_import_issue branch from e9012f3 to fcbb106 Compare March 12, 2025 03:59
DMwangnima
DMwangnima previously approved these changes Mar 12, 2025
View reviewed changes
@jayantxie jayantxie changed the title fix: code gen import issue for streamx mode, stream call judgement and set ttheader streaming as default fix: code gen import issue for streamx mode, stream call judgement bug and set ttheader streaming as default Mar 12, 2025
@jayantxie jayantxie merged commit 7690fa4 into develop Mar 12, 2025
41 checks passed
@jayantxie jayantxie deleted the fix/streamx_import_issue branch March 12, 2025 07:22
@BrewTestBot BrewTestBot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMwangnima DMwangnima DMwangnima approved these changes

@HeyJavaBean HeyJavaBean HeyJavaBean approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayantxie @DMwangnima @HeyJavaBean