Skip to content

feat: add tail option to support for delayed initialization of some client options #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

jayantxie
Copy link
Member

@jayantxie jayantxie commented Mar 10, 2025

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat: 添加 tail option 以支持部分client options的延迟执行

(Optional) More detailed description for this PR(en: English/zh: Chinese).

Client initialization logic in bytedance internal lib needs to perceive user configuration protocol information, and some options must be executed after all options are executed to get the protocol, so we add this api.

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners March 10, 2025 14:37
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.89%. Comparing base (efe7463) to head (74b2f5c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1724      +/-   ##
===========================================
+ Coverage    63.73%   63.89%   +0.16%     
===========================================
  Files          379      379              
  Lines        34319    34318       -1     
===========================================
+ Hits         21874    21929      +55     
+ Misses       11125    11082      -43     
+ Partials      1320     1307      -13     
Flag Coverage Δ
integration 47.78% <28.57%> (+0.10%) ⬆️
unit 55.74% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayantxie jayantxie force-pushed the feat/final_options branch from 33b6d88 to 2c5d74b Compare March 11, 2025 02:37
@jayantxie jayantxie changed the title optimize: add final options field to client options feat: add tail option to support for delayed initialization of some client options Mar 11, 2025
@jayantxie jayantxie force-pushed the feat/final_options branch from 2c5d74b to 74b2f5c Compare March 11, 2025 02:54
@jayantxie jayantxie merged commit 08e7206 into develop Mar 11, 2025
41 checks passed
@jayantxie jayantxie deleted the feat/final_options branch March 11, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants