Skip to content

feat: prutal for replacing protoc #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

xiaost
Copy link
Collaborator

@xiaost xiaost commented Mar 3, 2025

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

使用 prutal 替代 protoc

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:

  • protoc will be disabled by default
  • set KITEX_TOOL_USE_PROTOC=1 to enable protoc instead of using prutal

zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners March 3, 2025 06:09
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.77%. Comparing base (51b4a42) to head (8af843f).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1719   +/-   ##
========================================
  Coverage    63.77%   63.77%           
========================================
  Files          379      379           
  Lines        34425    34425           
========================================
+ Hits         21953    21954    +1     
- Misses       11155    11156    +1     
+ Partials      1317     1315    -2     
Flag Coverage Δ
integration 46.73% <ø> (-0.22%) ⬇️
unit 55.84% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaost xiaost force-pushed the prutal branch 8 times, most recently from 4f104cb to 969e81c Compare March 3, 2025 10:23
@xiaost xiaost force-pushed the prutal branch 4 times, most recently from 78c6aba to 554d7d8 Compare March 18, 2025 08:06
* protoc will be disabled by default
* set KITEX_TOOL_USE_PROTOC=1 to enable protoc instead of using prutal
@YangruiEmma YangruiEmma merged commit a6f265a into cloudwego:develop Mar 20, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants