fix(gRPC): golang CI Linter failure on http2Client #1706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1706 +/- ##
===========================================
- Coverage 57.41% 57.35% -0.07%
===========================================
Files 408 408
Lines 37693 37693
===========================================
- Hits 21643 21617 -26
- Misses 14733 14751 +18
- Partials 1317 1325 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1e4dee2 to
2cf03dc
Compare
ppzqh
approved these changes
Feb 18, 2025
jayantxie
approved these changes
Feb 18, 2025
DMwangnima
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
fix CI Linter:
Error: pkg/remote/trans/nphttp2/grpc/http2_client.go:314:2: SA4005: ineffective assignment to field closeStreamTask.toCloseStreams (staticcheck)
task.toCloseStreams = task.toCloseStreams[:0]
^
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: